search

enthought / envisage

Envisage is a Python-based framework for building applications whose functionalities can be extended by adding "plug-ins".
http://docs.enthought.com/envisage/
Other
80 stars 26 forks source link

Egg building tests leave 'build' directories behind #542

Closed mdickinson closed 1 year ago

mdickinson commented 1 year ago

Some of our tests dynamically build eggs. With current versions of setuptools and pip, that results in build directories being left behind in the source tree. We should be cleaning those build directories up. (The lack of cleanup is currently hidden by our .gitignore; we may want to fix this.)

mdickinson commented 1 year ago

We should also clean up the egg-info directories created.

mdickinson commented 1 year ago

Let's punt on this - it's not causing any real issues. We're already excluding build and egg-info directories in .gitignore, and all of the egg building machinery should be going away in Envisage 8.0 anyway. (xref: #548)

For the record, this was causing issues at one point during development because the built eggs were picking up the build directories as part of the package, leading to a several-layers-deep recursive inclusion of build directories. #543 fixed this particular issue by introducing specific inclusions in the find_packages calls in setup scripts.