enthought / ets

ets.py is a utility to clone and manage various Enthought Tool Suite packages
http://docs.enthought.com/ets
Other
34 stars 11 forks source link

Migrate on_trait_change to observe #61

Open aaronayres35 opened 3 years ago

aaronayres35 commented 3 years ago

A large amount of work has already been undertaken to move ETS projects from on_trait_change to observe. This includes replacing use of the static trait change handlers such as _*_changed and the use of depends_on in Property traits.

We would like to migrate all of ETS if possible but given the time/resource constraints, we are going to go with the 90%-10% option here. Given our experience, we know that 90% of the work is more-or-less straightforward whereas 10% of the work leads us down rabbitholes which require significant debugging/investigation. Therefore, at the moment, we are only going to attack the easy/straightforward 90% and ignore the hard/difficult 10% of changes.

Note also that in some packages, this work was completed but a release hasn't been published so the changes aren't visible to the users. We need to expose the changes to the users in order to catch any issues potentially not caught by the testsuites.

rahulporuri commented 3 years ago

Note : From the looks of it, we missed the _*_fired special methods.