enthought / graphcanvas

26 stars 8 forks source link

Fix GraphViz + pygraphviz integration #14

Open stevenjkern opened 6 years ago

stevenjkern commented 6 years ago

pygraphviz has recently become un-pip installable in continuous integration (and for me locally on OSX and linux). Some effort will be needed to figure out what the correct procedure for installing these libraries should be to reproducibly produce an environment with both installed. The CI recipes should also have entries in the testing matrix that have GraphViz+pygraphviz installed and not installed for each Python version and platform.

stevenjkern commented 6 years ago

At the same time, there should be a more elegant way of dealing with the chunks of code like this where we won't need to handle an ImportError in the body of a module: https://github.com/enthought/graphcanvas/blob/2b55904d6b33433baf850dc4149972b697128893/graphcanvas/graph_container.py#L51-L57