search

enthought / mayavi

3D visualization of scientific data in Python
http://docs.enthought.com/mayavi/mayavi/
Other
1.3k stars 284 forks source link

Settle on the supported versions of VTK for current MayaVi #1082

Open rahulporuri opened 2 years ago

rahulporuri commented 2 years ago

Update : We can definitely drop support for the old pipeline. See @prabhuramachandran's comment here - https://github.com/enthought/mayavi/issues/1082#issuecomment-932784187

It is not clear at the moment what versions of VTK are supported by the current (unreleased) versions of MayaVi. It would be good to settle this matter - and once decided, update the CI jobs to test against all supported versions of VTK. See https://github.com/enthought/mayavi/pull/1076 for the new GitHub Actions CI jobs that are being setup to replace the Travis and AppVeyor CI jobs.

rahulporuri commented 2 years ago

Note that at the moment, there is code which handles VTK version 5.8, version 6.2, version < 6 (representing the old pipeline) and version > 6 (representing the new pipeline). If we can settle on the supported versions, we can get rid of a lot of code e.g. remove code which handles the old pipeline.

Look for uses of vtk.vtkVersion for relevant code - https://github.com/enthought/mayavi/search?q=vtk.vtkVersion

rahulporuri commented 2 years ago

@prabhuramachandran do you have comments on this? Can we drop the old pipeline? What versions should we be supporting?

prabhuramachandran commented 2 years ago

@rahulporuri -- yes we can drop the support for the old pipeline. I am not sure if any of the enthought projects rely on older VTK versions, if they don't we can happily drop the old pipeline support.

rahulporuri commented 2 years ago

I am not sure if any of the enthought projects rely on older VTK versions, if they don't we can happily drop the old pipeline support.

I'm reasonably certain that no active Enthought project relies on the older pipeline/versions - mainly because all active development has moved to Python 3 and IIUC, the older version/pipeline (< 7) can't be used on Python 3.

rahulporuri commented 2 years ago

Additionally, note that VTK 8.1.x and 9.0.x are the only versions available via PyPI and Python 3 is only supported by VTK version >= 7. Given that, We can definitely remove support for VTK < 7.