enthought / mayavi

3D visualization of scientific data in Python
http://docs.enthought.com/mayavi/mayavi/
Other
1.28k stars 282 forks source link

MAINT: Support Python 3.12 #1281

Closed larsoner closed 6 months ago

larsoner commented 8 months ago

This isn't a good fix, but numpy.distutils is gone in Python 3.12. This should at least allow it to build in non-editable mode.

prabhuramachandran commented 8 months ago

Thanks @larsoner! What would be the best way to do this while supporting editable builds?

larsoner commented 8 months ago

Not sure. And several variants of what I have here do not seem to work, e.g. the patches used here:

https://github.com/conda-forge/mayavi-feedstock/pull/77

I think in theory the right move here is to migrate to using setuptools directly instead of anything numpy.distutils-related. But I'm not sure how trivial that will be...

tkoyama010 commented 8 months ago

To support Python3.12. We should be noted whether vtk's 9.3 will be compatible with Python 3.12. https://pypi.org/project/vtk

larsoner commented 8 months ago

Probably not on PyPI but conda-forge has it already, which triggered https://github.com/conda-forge/mayavi-feedstock/pull/77. See

I haven't tested it locally but I would be surprised if it did not work.

prabhuramachandran commented 6 months ago

@larsoner -- many thanks for this. Sorry for the delay in merging this.