search

enthought / mayavi

3D visualization of scientific data in Python
http://docs.enthought.com/mayavi/mayavi/
Other
1.28k stars 282 forks source link

MAINT: Compile with Cython 3.0.10 #1303

Open larsoner opened 1 month ago

larsoner commented 1 month ago

Compiled while on NumPy 2.0rc2 (though I doubt this matters) and Cython 3.0.10.

larsoner commented 1 month ago

@prabhuramachandran taking a stab at https://github.com/enthought/mayavi/pull/1301#issuecomment-2132411224, it seems like things are complicated if we try to support Python 3.8 since there is no NumPy 2.0 for Python 3.8. Okay to bump to 3.9?

prabhuramachandran commented 1 month ago

@prabhuramachandran taking a stab at #1301 (comment), it seems like things are complicated if we try to support Python 3.8 since there is no NumPy 2.0 for Python 3.8. Okay to bump to 3.9?

Thanks for doing this. Yes, I am perfectly fine with dropping 3.8 and moving to 3.9 for the tests. I just changed the branch protection rules so the checks look OK now. So I will just go ahead and merge this after a quick review.