search

enthought / pyface

pyface: traits-capable windowing framework
Other
106 stars 55 forks source link

Use a weakref to the window that the EventFilter is attached to #1093

Closed corranwebster closed 2 years ago

corranwebster commented 2 years ago

Fixes #1081.

corranwebster commented 2 years ago

Right now a blunt test is that the test suite segfaults in PySide6 without this fix. I'll think through if there is a way to test this independently without either getting too hung up on implementation details and given the constraints of trying to test around object finalization.

corranwebster commented 2 years ago

I've added an issue for testing, as I think it is a larger problem than just this PR: https://github.com/enthought/pyface/issues/1097