search

enthought / pyface

pyface: traits-capable windowing framework
Other
105 stars 55 forks source link

BUG: Remove cycle on cleanup. #1143

Closed rkern closed 2 years ago

rkern commented 2 years ago

This cycle does not appear to matter on PyQt5, but will persist in PySide2 and PySide6.

This cleanup is required in order to port Mayavi to PySide6, at least without adding more test skips for Mayavi tests that try to determine if forgetting about DecoratedScene objects (which make toolbars) doesn't leave cycles.

I could add tests here if we wanted to introduce gc-using tests to pyface.

rkern commented 2 years ago

cycles-0

Similar results occur for PySide2, but not on PyQt5.

(And yes, thanks @mdickinson for mdickinson/refcycle. Lifesaver.)