search

enthought / pyface

pyface: traits-capable windowing framework
Other
105 stars 55 forks source link

Add temporary pin for PySide6 version #1169

Closed mdickinson closed 1 year ago

mdickinson commented 1 year ago

This PR temporarily pins the PySide6 version in CI, to give us breathing space to adapt to the backwards-incompatible Enum-related changes introduced in PySide6 6.4.0.

mdickinson commented 1 year ago

@corranwebster I'm running into quoting issues on Windows. Any suggestions about how to fix?

corranwebster commented 1 year ago

@corranwebster I'm running into quoting issues on Windows. Any suggestions about how to fix?

No. I ended up just skipping the EDM Windows/PySide6 combination in CI for the equivalent PR in TraitsUI.

I think it might be fixable by refactoring etstool to pass lists of strings that form a command, rather than a single string, but I didn't have time to do that.

In general the etstools need a bit of a refactor, particularly given the improvements in pip and other related tooling.

mdickinson commented 1 year ago

Looks like I've finally found the right combination.