search

enthought / pyface

pyface: traits-capable windowing framework
Other
104 stars 55 forks source link

Fix problem with multiple matches to shadowed module finder #1228

Closed corranwebster closed 1 year ago

corranwebster commented 1 year ago

This checks against the possibility of the ShadowedModuleFinder being used with different modules (eg. potentially other ETS modules)

corranwebster commented 1 year ago

Minor suggestion, orthogonal to this PR: would it make sense to remove the defaults from the implementation of ShadowedModuleFinder.__init__ and pass them explicitly at ShadowedModuleFinder creation time?

Possibly - I had them hard-coded because I didn't know whether or not I was going to copy or import in TraitsUI. I may still end up copying, so I will leave as-is for now until the TraitsUI analogue PR is merged.