search

enthought / pywin32-ctypes

A (partial) reimplementation of pywin32 in pure python
Other
18 stars 9 forks source link

Cffi wrappers #31

Closed itziakos closed 9 years ago

itziakos commented 9 years ago

requires #30 to be merged before

itziakos commented 9 years ago

@cournape, this PR is ready for review

itziakos commented 9 years ago

finally the tests pass.

cournape commented 9 years ago

LGTM.

I have not looked at the details, but the new cffi >= 1.0 has some interesting improvements regarding code organization and import speed (see also https://cffi.readthedocs.org/en/latest/overview.html)

We have the latest cffi in our repo FWIW (1.0.3 as we speak)

cournape commented 9 years ago

Actually, it would be good to mention cffi in the README.

It would also be good to consider testing pypy (without pywin32 of course).

itziakos commented 9 years ago

It would also be good to consider testing pypy (without pywin32 of course).

Since it will require to have a new set of tests. I think that it should be part of a new PR. Is that ok?

itziakos commented 9 years ago

I have not looked at the details, but the new cffi >= 1.0 has some interesting improvements regarding code organization and import speed (see also https://cffi.readthedocs.org/en/latest/overview.html)

Yes, there is a new way of providing ABI access to dlls but I think it requires a compiler.

itziakos commented 9 years ago

@cournape I have updated the readme and cleanedup the CI builts. I also added an issue about testing without pywin32. Please have another look

itziakos commented 9 years ago

@cournape is this ok to merge?

itziakos commented 9 years ago

@cournape ping

cournape commented 9 years ago

LGTM