Remove broken _unsatisfied_clauses cache

enthought / sat-solver

Default Repo description from terraform module

Other

3 stars 1 forks source link

Remove broken _unsatisfied_clauses cache #269

Closed mdickinson closed 5 years ago

mdickinson commented 5 years ago

Fixes #268, by removing the machinery for the _unsatisfied_clauses cache. That machinery is broken in two ways:

the _unsatisfied_clauses set isn't ever initialised properly
the collection of unsatisfied clauses isn't updated when the set of clauses changes (as can happen with the current solver algorithm)

I'd really like to get rid of the changelog too, but we're currently using it for logging purposes.

mdickinson commented 5 years ago

One other thing: if we do want to reimplement something like this cache, I think it would be the solver's job to maintain that cache. We might consider different data structures to organise the information, that would make retrieving the set of unsatisfied clauses more efficient.

mdickinson commented 5 years ago

@jvkersch I don't know if you have any bandwidth for review, but if you do I'd very much appreciate a second pair of eyes on this.