search

enthought / tabs

Default Repo description from terraform module
0 stars 0 forks source link

Visualize salinity contours #38

Closed johntyree closed 9 years ago

johntyree commented 9 years ago

This PR is the final piece for the first draft of #16 and #9.

It builds on #36.

The hardest part of this by far is getting the call to contour correct. Most things that I have tried have resulted in worthless rectangles in tiny bays along the coast and nothing else.

The good news is that the plotting side appears to work fine.

kjordahl commented 9 years ago

Works for me! Looks nice.

I'm getting ~1.5 fps while loading a local file, and ~7 fps subsequent times through.

kjordahl commented 9 years ago

This is hanging for me sometimes. I'm having trouble getting it started consistently.

I'm going to hold off merging this until I figure out what's going on.

johntyree commented 9 years ago

It's currently set not to start running by default and there's still no good indication of that or how to start it anywhere. Is that what you're seeing?

johntyree commented 9 years ago

The interaction between the two layers still isn't quite right, and yes, performance is pretty rough. It would probably be decent if the simplification step in matplotlib was working properly. With no delay I get about 20fps for the vectors alone.

kjordahl commented 9 years ago

The simplification is tricky, in general since the polygons aren't topologically aware, neighboring ones would be simplified differently along common boundaries. Topojson could do this, but adds another translation step at each end. (It should be pretty easy at the front end, though.)

johntyree commented 9 years ago

I'll take a look at topojson tomorrow. We might be able to get away with performance as it is if the countour layer can be simplified.

kjordahl commented 9 years ago

LGTM. Performance issues are important, topojson is one possible remedy.

I'll merge and we'll address it from there.