search

enthought / tabs

Default Repo description from terraform module
0 stars 0 forks source link

Switch to WebGL for the vectors #66

Closed johntyree closed 8 years ago

johntyree commented 8 years ago

This thing is smokin! :racehorse:

WebGL4Lyfe.

For some reason a huge chunk of a previous PR was missing. I still had the local branch so it's back here now.

What actually happened is that I borked the merge because it's 4 am. Fixed now.

See the static version here: http://enthought.github.io/tabs

kjordahl commented 8 years ago

This is a huge improvement! A few minor comments, but this looks really good.

johntyree commented 8 years ago

If you really want to see it get interesting, open the console and set mapView.delay = 0.

I get 30-50 FPS in firefox and :fire:130-150:fire:in Chrome!

kjordahl commented 8 years ago

I think we need a canvas overlay with a clear license, then we can merge.

johntyree commented 8 years ago

I'll dig around a little more and see if I can find it, otherwise I'll work on switching it over.

kjordahl commented 8 years ago

Conflict introduced by merging #69 (I think it's just the polyfill include in tabs.html).

johntyree commented 8 years ago

So this "works" now. There are several things about it that are kind of ugly and probably several places where I'm not being very efficient (recreating arrays, etc), but those can be new PRs.

We're also now based off of https://github.com/CartoDB/Leaflet.CanvasLayer, which is explicitly MIT.

kjordahl commented 8 years ago

Working great, I'm going to merge and we can look for places to clean up if we get a chance. Performance is really good.