search

enthought / tabs

Default Repo description from terraform module
0 stars 0 forks source link

Patch in Number.isFinite if it's missing #69

Closed johntyree closed 8 years ago

johntyree commented 8 years ago

Closes #53

Note that you still need to go do some work as a user.

  1. File -> Preferences -> Advanced -> Show Develop Menu
  2. Develop -> Enable WebGL

We should be able to detect that WebGL is unavailable and try to do something smart, but that's not in the cards for the very near term.

kjordahl commented 8 years ago

WebGL is enabled by default in Safari 8.0 (apparently since 7.1, actually). I think that means OS X 10.9 (Mavericks) and up.

johntyree commented 8 years ago

Then everything should just work. With WebGL enabled and this patch, I had it working in Safari this morning.

kjordahl commented 8 years ago

:+1:

Confirmed that this patch on top of #66 works on Safari (8.0.8 on OS X 10.10.15).

We could try to detect earlier Safari versions without WebGL enabled, I'll defer that for now.