search

enthought / tabs

Default Repo description from terraform module
0 stars 0 forks source link

Allow switching data sources #90

Closed kjordahl closed 8 years ago

kjordahl commented 8 years ago

Introduce multiple data sources. Currently can toggle between forecast and hindcast.

Not quite complete, needs to update timestamps on switching data sources, and clean up a few more things.

johntyree commented 8 years ago

Can you also update the script that pulls down the netcdf files for the cached data to get this new one?

kjordahl commented 8 years ago

Can you also update the script that pulls down the netcdf files for the cached data to get this new one?

Will do. Also the --cached flag is broken, because it doesn't actually use them.

johntyree commented 8 years ago

Yes, I was just looking at fixing that now.

kjordahl commented 8 years ago

One bug that needs to be fixed before merging this is that going past the end of the forecast data kills it. Should handle 404's gracefully.

kjordahl commented 8 years ago

Actually working now, with minor glitches remaining. The number of time steps switches correctly, but the length of the slider doesn't reflect that, for example.

kjordahl commented 8 years ago

It still doesn't handle 404s gracefully, it just avoids them in the common case of switching to a data source with fewer steps available.

kjordahl commented 8 years ago

Set the default number of frames to 30 for now for consistency with the forecast data. This makes switching back and forth easier. Changing the number of frames will need some work to update the slider (otherwise it would still be possible to drag it past the end of the data).

I think this is ready to merge now.

johntyree commented 8 years ago

LGTM

johntyree commented 8 years ago

Except for the bug i just introduced.