search

enthought / tabs

Default Repo description from terraform module
0 stars 0 forks source link

Add a Date/Time picker widget #93

Open johntyree opened 8 years ago

johntyree commented 8 years ago

This sets mapView.startTime to the epoch time corresponding to whatever has been selected in the widget.

The widget always shows this start time and does not update with the slider.

The widget is, unfortunately, quite hideous.

johntyree commented 8 years ago

Additionally, I noticed that we were claiming to show UTC but actually showing some strange mixture of UTC and local zoned time. This should fix that.

johntyree commented 8 years ago

This needs a little more bookkeeping put into it.

johntyree commented 8 years ago

This widget is Apache licensed. https://github.com/tarruda/bootstrap-datetimepicker/blob/master/LICENSE

kjordahl commented 8 years ago

The widget looks good, but I see two issues:

johntyree commented 8 years ago
  1. The pitcher sets a startTime attribute on the map view. I didn't know how it was going to be used because I hadn't seen your api changes yet. I assumed we would be able to set that once it was clear how to use it.
  2. I'm not sure it has a way to step input time like that, but we can snap results to the nearest data time stamp. On Sep 1, 2015 12:49 AM, "Kelsey Jordahl" notifications@github.com wrote:

The widget looks good, but I see two issues:

  • Changing the start date doesn't have an effect on the mapView. Missing a piece of wiring here?
  • The time portion of the widget should probably be fixed to 4-hour intervals

— Reply to this email directly or view it on GitHub https://github.com/enthought/tabs/pull/93#issuecomment-136593036.

johntyree commented 8 years ago

I'm just going to sit this on top of https://github.com/enthought/tabs/pull/95

johntyree commented 8 years ago

a final PR might be to make this a little less hideous. Maybe stick it in a modal or something instead of where it is now.