search

enthought / terraform-modules

Reusable terraform modules
BSD 3-Clause "New" or "Revised" License
26 stars 17 forks source link

aws_secret_store module #1

Closed mplanchard closed 6 years ago

mplanchard commented 6 years ago

This module was broken out as a part of the in-progress modularization of the brood docker cluster.

It is designed to work with our existing secrets.py module and future package.

It creates an S3 bucket, KMS keys for each deploy environment, and access policies for each environment allowing secret retrieval and decryption. An existing S3 bucket may be used instead of having one created.

Outputs are generally maps with keys corresponding to the deploy environment.

This PR also includes the terraform style githook from our terraform module (see enthought/terraform#7 for details).

Upon merging, we should go ahead and create a tag pointing to the master branch so that the module can be pointed to via a git reference. We should consider ways towards automation of tagging as we go forward.

mplanchard commented 6 years ago

Forgot to push my ProvisionedBy tags yesterday, and addressed the directory typo

mplanchard commented 6 years ago

@dpinte this is ready for re-review

mplanchard commented 6 years ago

@dpinte could I get a review on this? I've got a docker_cluster module ready to go as well, but I built it on top of this one, so I can't open that one until this one is merged.