search

enthought / terraform-modules

Reusable terraform modules
BSD 3-Clause "New" or "Revised" License
26 stars 17 forks source link

Update Managed_Repository module #14

Open dbolack opened 5 years ago

dbolack commented 5 years ago

Add lifecycles to githubteam memberships set merge_commit default to true

The hope/expectation is that the lifecycle change will prevent a team from being removed from a repository once it is empty during the list rebuild cycle when a team member is removed ( pre 0.12 )

dpinte commented 5 years ago

@dbolack I don't think the lifecycle change will do the right thing. From what I understand, Terraform will do the planning, define what needs to be deleted and created, and then based on the lifecycle attribute do the deletion first or the creation first. I wonder how it will work with the GH team membership as it will still define the resource to be created/deleted based on the indexing in the list of members. Did you test it?

I think the only reasonable solution going forward before TF 0.12 is available is to use a templating system.

dbolack commented 5 years ago

Fuller testing is on today's plan. I wanted this up and commentable in case someoen already knew it was down the wrong path.