search

enthought / traits

Observable typed attributes for Python classes
Other
432 stars 85 forks source link

Remove a test that uses UITester #1788

Closed mdickinson closed 5 months ago

mdickinson commented 5 months ago

This PR removes a test that's using UITester from TraitsUI. This test exposed the Traits test suite to a class of possible issues with 3rd party GUI frameworks (in this case PySide6); historically, UITester has also been a particularly fragile part of TraitsUI.

In its place is a test that at least executes the Enum.create_editor method, but doesn't attempt to create an instance of the editor.

We also fix an issue with test dependencies and the latest release of Sphinx: defusedxml is now required to run the tests for the Traits documenter.

Closes #1787

mdickinson commented 5 months ago

Updated to add back a test that at least exercises the Enum.create_editor method.

mdickinson commented 5 months ago

@flongford Do you have bandwidth to review?

CI is unfortunately still failing because of an orthogonal issue, that's fixed separately in #1789.

mdickinson commented 5 months ago

The issue with Python 3.8 and Python 3.9 no longer being available on macos-latest runners has been resolved upstream. I'm made a tiny commit to this PR to add "defusedxml" to the test dependencies - without this, some of the Sphinx tests were failing.

If the CI passes, I'll merge.

mdickinson commented 5 months ago

I've also updated the PR description.

Merging!