Fix a race condition in a multithreaded test

enthought / traits

Observable typed attributes for Python classes

Other

421 stars 85 forks source link

Fix a race condition in a multithreaded test #1798

Closed mdickinson closed 1 month ago

mdickinson commented 1 month ago

This PR fixes an obvious race condition in a test - we're firing off an action in a background thread, but not waiting for that background thread to complete before checking for the side-effects that we're expecting.

This caused a CI failure in a recent Windows run: https://github.com/enthought/traits/actions/runs/9164818354/job/25196928783?pr=1797

mdickinson commented 1 month ago

@flongford An easy one for you ...

mdickinson commented 1 month ago

Thanks for review! Merging.