search

entria / react-native-fontawesome

React Native Font Awesome Icons
MIT License
176 stars 34 forks source link

Update README.md #51

Closed A-Shleifman closed 5 years ago

A-Shleifman commented 5 years ago

Forgot to mention the expected fontFamily format in the last commit.

A-Shleifman commented 5 years ago

What do you think about updating Icon.js to match font file names?

const IconTypes = {
  FAR: Platform.OS === 'ios' ? 'FontAwesome5FreeRegular' : 'fa-regular-400',
  FAS: Platform.OS === 'ios' ? 'FontAwesome5FreeSolid' : 'fa-solid-900',
  FAB: Platform.OS === 'ios' ? 'FontAwesome5BrandsRegular' : 'fa-brands-400'
}
leandrosimoes commented 5 years ago

What do you think about updating Icon.js to match font file names?

const IconTypes = {
  FAR: Platform.OS === 'ios' ? 'FontAwesome5FreeRegular' : 'fa-regular-400',
  FAS: Platform.OS === 'ios' ? 'FontAwesome5FreeSolid' : 'fa-solid-900',
  FAB: Platform.OS === 'ios' ? 'FontAwesome5BrandsRegular' : 'fa-brands-400'
}

Done @A-Shleifman: https://github.com/entria/react-native-fontawesome/pull/52

A-Shleifman commented 5 years ago

@leandrosimoes, Great, thanks! Then we don't need to update Readme.md