search

entrippy / OctoPrint-OctoHue

Illuminate your print job and signal its status using a Philips Hue lights.
GNU Affero General Public License v3.0
18 stars 4 forks source link

Lights up with 255 brightness and don't accept settings when using toggle #31

Open w4ters opened 4 years ago

w4ters commented 4 years ago

Here you can see my settings: https://prnt.sc/rdzh7u

Turn on/off works like a charm. I want my bulb lights up on the smallest brightness. But no matter what i give for settings, it will light up with full brightness.

entrippy commented 4 years ago

Hi @w4ters thanks for including a screen shot.

I think I've spotted the problem (I'm not sending the key for brightness along with the value). I'll need to wait until i get home to write and test it. If all goes according to plan I'll push 0.4.3 tonight with the fix.

entrippy commented 4 years ago

Hi @w4ters , this should now be fixed. I'd appreciate it if you could confirm if it looks good to you.

w4ters commented 4 years ago

Maybe a dumb question, but how do i manually update the plugin?

entrippy commented 4 years ago

Does Update manager in settings pick it up?

w4ters commented 4 years ago

Ok got it updated. Had to use the function without the cache.

Tested it, it will stay at that brightness whatever i have choosen via the Hue App. Example: Hue App Lamp 1%. I toggle off via Octohue = Toggled off I toggle on via Octohue (basic settings brightness 5%) = it toggles on very lowlight. I change the brightness via Hue App to 100% = works I toggle off via Hue App = works I toggle on via Octohue (still 5%) = it turns on with 100%

Seems like the brightness is still a bit broken

entrippy commented 4 years ago

Ahhh... You're using the toggle icon? Or via a state change (e.g going from disconnected to connected)?

w4ters commented 4 years ago

So far only the toggle icon. With the icon the bugs is still there.

Tested now with connected and disconnected state, this works now like a charm :)