entropia / libsocket-can-java

SocketCAN JNI wrapper
MIT License
44 stars 49 forks source link

Remove warnings due to unused parameters. #9

Closed yegorich closed 11 years ago

yegorich commented 11 years ago

Signed-off-by: Steve Schefter steve.schefter@timesys.com Tested-by: Yegor Yefremov yegorslists@googlemail.com

hannes-zz commented 11 years ago

The change is ok and would not break anything. Because it would make the code more clumsy, what do you think if we specify -Wno-unused-parameter (or something like that) in the Makefile?

yegorich commented 11 years ago

I haven't seen such warnings on my Xubuntu host, only Android's NDK complained. So I'll just use this flag for my Android build system.

Adding this flag to Makefile won't do any harm either.

hannes-zz commented 11 years ago

On Fri, Sep 20, 2013 at 05:38:17AM -0700, Yegor Yefremov wrote:

I haven't seen such warnings on my Xubuntu host, only Android's NDK complained. So I'll just use this flag for my Android build system.

Adding this flag to Makefile won't do any harm either.

I just added the flag and pushed the change.

Greetings,

Hannes