search

entropia / paperless-asn-qr-codes

GNU General Public License v3.0
24 stars 18 forks source link

ci suggestions #9

Closed jcgruenhage closed 6 months ago

jcgruenhage commented 7 months ago

I've adjusted the hatch and ci config slightly, in a way that I find cleaner. @margau, what do you think about this? I'm targeting your PR with my PR here, so it'd add to yours, and you can squash the fixup commit into yours if you want to get include this.

margau commented 7 months ago

I'm a bit confused over the removal of black (thats why i've left it initially): The FAQ states on the one hand, that ruff is a drop in replacement (https://docs.astral.sh/ruff/faq/#how-does-ruffs-formatter-compare-to-black), but on the other hand, that ruff should be used alongside black (https://docs.astral.sh/ruff/faq/#how-does-ruffs-linter-compare-to-flake8) to replace flake8.

But for this project, it is probably okay to go forward as it is without black?

jcgruenhage commented 7 months ago

As far as I understand, ruff is a drop in replacement, that should emit a similar code style to black, and it's designed so that it can be used alongside black. When run over black formatted code, it should change anything.

As we don't really have any requirements here to also keep black around, I'd just go for ruff alone, as from what I read it should already fulfill everything that we need.