`welcome` field trims quoted filenames

cstuder commented 2 years ago

Consider the following YAML:

product-id: 900
welcome: "01 welcome.ogg"
scripts:
  ...

When assembling, this will search for the audio file 01.ogg instead of 01 welcome.ogg.

tttool 1.10 on MacOS 11.6.1.

nomeata commented 2 years ago

Hmm, odd. Maybe it's because welcome can actually be a sequence of files? But yes, I should look into this when I have a quiet minute.

nomeata commented 2 years ago

Ok, I debugged this. There are a few things coming together:

The welcome field is a string of comma-separated audio names, e.g. as in this idiomatic use:
```
welcome: pling, hello
```
Usually, audio file names are just characters, numbers, _ and .. tttool does support quoted named, but the quotes in your example are actually consumed by YAML, so it’s the same as
```
welcome: 01 welcome.ogg
```
Because of a bug in tttool, it would not complain if the parser can’t understand the full input. So it parses the 01, can’t make sense of what follows, but silently ignores it, and then searched fro 01.ogg.

With the last point fixed you’ll get an error message like

In welcome column 4:
01 welcome.ogg
   ↑
unexpected 'w'
expecting "," or end of input

It’s still easiest to avoid spaces in filenames :-)

entropia / tip-toi-reveng