search

entropic-dev / entropic

🦝 :package: a package registry for anything, but mostly javascript 🦝 🦝 🦝
https://discourse.entropic.dev/
Apache License 2.0
5.29k stars 151 forks source link

ds build puts modiules into 'ds' subfolder #254

Closed fetis closed 5 years ago

fetis commented 5 years ago

Is this a feature request or a bug?

it seems bug for me

Expected behavior:

put packages into node_modules

Actual behavior:

packages are in ds/node_modules

Steps to replicate:

so, I have fresh master and I did npm link in cli folder to install ds globally.

I have next Package.toml

name = "fetis@entropic.dev/test"
version = "0.0.0-beta"

[dependencies]
"legacy@registry.entropic.dev/figgy-pudding" = "^3.5.1"

I run ds build. The package is installed but into ds subfolder

So node module resolution is broken const figgy = require('figgy-pudding');

Environment info (where relevant)

Is it expected behavior or a bug?

P.S. I tried the same with an older version from install.sh script -- same result.

toddself commented 5 years ago

From the README:

At present, if you want to install packages using ds, you can run ds build in a directory with a Package.toml. This will produce a ds/node_modules directory, which you can move into place by hand. This is a temporary situation!

This works as expected (for now!)

fetis commented 5 years ago

What's the problem to put it directly to the node_modules? If I want to fix this behavior...

toddself commented 5 years ago

Since this is still very beta I think there is some worry about hosing a working installation, especially given issues like #266 exist.

toddself commented 5 years ago

I'm gonna close this in lieu of a conversation about what "not being in beta" means on the discourse! (Please feel free to re-open if this doesn't solve your needs!)