fix(install): change hash for type on install script

entropic-dev / entropic

🦝 :package: a package registry for anything, but mostly javascript 🦝 🦝 🦝

https://discourse.entropic.dev/

Apache License 2.0

5.29k stars 152 forks source link

fix(install): change hash for type on install script #315

Closed juanarbol closed 4 years ago

juanarbol commented 5 years ago

Change Type (Feature, Chore, Bug Fix, One Pager, etc.)

Fix

Description

I changed hash for type because it was actually not falling to elif and else code blocks, just emit exception hash: no such command: ... and just put the ds on a variable because it was actually the same

Also I redirect stderr and stdout to /dev/null because type prints command is /route in stdout

How to test

Run ./misc/install.sh on root folder

Checklist

[ ] Added tests / did not decrease code coverage
[ ] Tested in supported environments (common browsers or current Node)

zacanger commented 5 years ago

Interesting that hash wasn't working for you, what system and shell are you on? type seems potentially slightly more dangerous, because hash specifically checks for programs, and type also checks for aliases, functions, and builtins.

juanarbol commented 5 years ago

Zsh on High Sierra

juanarbol commented 5 years ago

Sorry, It actually works! It was a lapsus of me, now just put tarball resource on a variable, updated in aaf12fa

Sorry, again, my bad

zacanger commented 5 years ago

Oh, cool! I was having a minor panic attack thinking I forgot something about how hash works :laughing:

juanarbol commented 5 years ago

I do not know if this "contribution" has any real value, close this pull request in case of this is not really needed