UF: Adding the unbalanced penalization paper and solving some issues

alejomonbar commented 1 year ago

I decided to divide draft #181 into two. One for the issues with FromDocplex2IsingModel and the other for the bin packing problem. The problem is that the function does not raise an error when it appears. Additionally, I have included the link for the unbalanced penalization paper (https://arxiv.org/abs/2211.13914).

Description

I modified the file converters where the FromDocplex2IsingModel is. I found some issues and needed to add a link to the paper.

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code and used numpy-style docstrings
[ ] I have made corresponding updates to the documentation.
[ ] My changes generate no new warnings
[ ] I have added/updated tests to make sure bugfix/feature works.
[ ] New and existing unit tests pass locally with my changes.

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Name the new unit-tests that you have added along with this change.

codecov[bot] commented 1 year ago

Codecov Report

Merging #198 (a1467be) into dev (6140672) will decrease coverage by 8.94%. The diff coverage is 100.00%.

:exclamation: Current head a1467be differs from pull request most recent head 908ddf0. Consider uploading reports for the commit 908ddf0 to get more accurate results

@@            Coverage Diff             @@
##              dev     #198      +/-   ##
==========================================
- Coverage   97.72%   88.79%   -8.94%     
==========================================
  Files          37       32       -5     
  Lines        6776     5799     -977     
==========================================
- Hits         6622     5149    -1473     
- Misses        154      650     +496

Impacted Files	Coverage Δ
tests/test_converters.py	`100.00% <100.00%> (ø)`

... and 17 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

vishal-ph commented 1 year ago

@alejomonbar, the tests are failing because your branch has an older version of .github/workflows/test_dev.yml. You can update your branch by pulling from dev. Then we can try running the tests again

alejomonbar commented 1 year ago

I updated this branch @vishal-ph

entropicalabs / openqaoa