entropicalabs / openqaoa

Multi-backend SDK for quantum optimisation
MIT License
119 stars 58 forks source link

fixed file name dump method workflows #200

Closed raulconchello closed 1 year ago

raulconchello commented 1 year ago

The dump method was giving the following name: {experiment_id}--{atomic_id}

the correct one is: {project_id}--{experiment_id}--{atomic_id}

codecov[bot] commented 1 year ago

Codecov Report

Merging #200 (54d0c70) into dev (9d39cb1) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #200      +/-   ##
==========================================
+ Coverage   88.79%   88.81%   +0.02%     
==========================================
  Files          32       32              
  Lines        5799     5812      +13     
==========================================
+ Hits         5149     5162      +13     
  Misses        650      650              
Impacted Files Coverage Δ
tests/test_workflows.py 99.50% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Q-lds commented 1 year ago

@raulconchello what's the default value for the project id?

Project_id has to be a valid uuid4, it is provided by the user, and it now becomes necessary. That is, if no project id is specified what happens when one tires to save the result?