ParamStore merge() now correctly marks store as is_dirty when needed

entropy-lab / entropy

BSD 3-Clause "New" or "Revised" License

30 stars 13 forks source link

ParamStore merge() now correctly marks store as is_dirty when needed #170

Closed urig closed 2 years ago

urig commented 2 years ago

This PR fixes issue https://github.com/entropy-lab/entropy/issues/168. The ParamStore merge() method has been modified to set self._is_dirty to True if the merge operation changed the current state of the store (i.e. _self.params).

Note: the internal implementation for MergeStrategy.THEIRS has been significantly changed to enable the fix.

github-actions[bot] commented 2 years ago

Unit Test Results

    1 files     1 suites 49s :stopwatch: 191 tests 187 :heavy_check_mark: 4 :zzz: 0 :x:

Results for commit dad96209.

:recycle: This comment has been updated with latest results.

urig commented 2 years ago

@urig please fix formatting

Tx Done