search

entropy-lab / entropy

BSD 3-Clause "New" or "Revised" License
30 stars 13 forks source link

Making InProcessParamStore thread-safe #171

Closed urig closed 2 years ago

urig commented 2 years ago

This PR makes InProcessParamStore thread-safe.

A single mutually exclusive lock (threading.Lock) has been added around all critical sections. I.e. whenever a public method reads or changes state data (i.e. self._params, self_tags etc.) it acquires the lock and releases it afterwards.

github-actions[bot] commented 2 years ago

Unit Test Results

    1 files      1 suites   50s :stopwatch: 191 tests 187 :heavy_check_mark: 4 :zzz: 0 :x:

Results for commit ef078177.

galwiner commented 2 years ago

@qguyk needs to look over this, it's above my head. Regardless, there's a conflict at the moment which should be resolved @urig