search

entropy-lab / entropy

BSD 3-Clause "New" or "Revised" License
30 stars 13 forks source link

ParamStore list_values() now returns a pd.datetime instead of a datatime #181

Closed urig closed 2 years ago

urig commented 2 years ago

This PR resolves issue https://github.com/entropy-lab/entropy/issues/160.

The root cause of the issue was that the implementation of ParamStore's list_values() method was converting nanosecond precision timestamp to Python datetimes. As Python's datetime has lower precision that the timestamps, a warning was raised indicating the loss of precision.

This PR makes a small, albeit breaking, change to list_values(): It now returns pd.datetime values, therey by preserving the original precision of the timestamps and avoiding the warning.

github-actions[bot] commented 2 years ago

Unit Test Results

    1 files      1 suites   53s :stopwatch: 194 tests 190 :heavy_check_mark: 4 :zzz: 0 :x:

Results for commit bc1b45ff.

:recycle: This comment has been updated with latest results.