entropy-lab / entropy

BSD 3-Clause "New" or "Revised" License
30 stars 13 forks source link

New Plotting API based on plot.ly figures #195

Closed urig closed 2 years ago

urig commented 2 years ago

This PR introduces a new API for plotting experiment results. The new API is based on the popular Plotly open source graphing library - primarily on its concept of figures.

When users run their experiments they can now describe visualization of experimental results using Plotly's go.Figure class and then save the visualization using the new add_figure() method. The Entropy Dashboard application (invoked using entropy serve) will read the figures from the Entropy database and render them on screen for analysis and aggregation.

The new API is a replacement for the existing API which was based on our own python based DSL for describing 2d and 2d plots. Methods of the existing API have been marked with PendingDeprecationWarnings and will soon be removed.

Breaking changes:

github-actions[bot] commented 2 years ago

Unit Test Results

    1 files      1 suites   51s :stopwatch: 196 tests 192 :heavy_check_mark: 4 :zzz: 0 :x:

Results for commit 6afae1e1.

:recycle: This comment has been updated with latest results.

urig commented 2 years ago

@urig @galwiner looks good :) if you ran it manually (in the last version) and it seems ok - so i think we can merge (just the two small comments). @urig can you squash your commits to more meaningful messages?

Verified manually and squashed commits - Ready to merge imho :)

galwiner commented 2 years ago

@qguyk can we merge this PR?