search

entropy-lab / entropy

BSD 3-Clause "New" or "Revised" License
30 stars 13 forks source link

paramstore uses GMT and not local time when time stamping commits #221

Closed galwiner closed 2 years ago

galwiner commented 2 years ago

when calling commit, the "ns" time stamp for the commit uses GMT and not the local timezone also I wonder if "ns" is not a misleading name and should be changed to "time-stamp"

urig commented 2 years ago

We store the ns timestamp as UTC so as to have it store the absolute moment in time regardless of the timezone. Based on this we can render to the user in list_commits() that same moment as seen in their local timezone.

I will rename ns to timestamp in commit Metadata to increase readability.