entropy-lab / entropy

BSD 3-Clause "New" or "Revised" License

30 stars 13 forks source link

Update graph.py: fix bug in `.ancestors()` method #255

Closed eunjongkim closed 2 years ago

eunjongkim commented 2 years ago

take into account node dependencies specified by kwarg must_run_after (ones without passing variables between nodes) when finding ancestors

replace this template text

Fixing a bug reported in Issue #248

Remember to:

Update the CHANGELOG.md
Added tests for the feature or fix

github-actions[bot] commented 2 years ago

Unit Test Results

221 tests 217 :heavy_check_mark: 53s :stopwatch:     1 suites     4 :zzz:     1 files     0 :x:

Results for commit 0fc4fb67.

:recycle: This comment has been updated with latest results.

qguyk commented 2 years ago

@eunjongkim Thank you for opening this PR. The fix looks good. We have Formatting and Linting rules for this repo, I've pushed a new commit to your branch to follow those. For the next time, you can set and run the automatic tools by running: poetry install poetry run poe format and check for errors poetry run poe check