codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 90.74% and project coverage change: -0.84 :warning:
Comparison is base (
c2fad8b) 99.45% compared to head (df3e846) 98.62%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #22 +/- ## ========================================== - Coverage 99.45% 98.62% -0.84% ========================================== Files 9 10 +1 Lines 1286 1306 +20 ========================================== + Hits 1279 1288 +9 - Misses 7 18 +11 ``` | [Impacted Files](https://codecov.io/gh/entropyxyz/crypto-primes/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz) | Coverage Δ | | |---|---|---| | [src/hazmat/precomputed.rs](https://codecov.io/gh/entropyxyz/crypto-primes/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL2hhem1hdC9wcmVjb21wdXRlZC5ycw==) | `0.00% <0.00%> (ø)` | | | [src/presets.rs](https://codecov.io/gh/entropyxyz/crypto-primes/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL3ByZXNldHMucnM=) | `99.00% <95.00%> (-1.00%)` | :arrow_down: | | [src/hazmat.rs](https://codecov.io/gh/entropyxyz/crypto-primes/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL2hhem1hdC5ycw==) | `100.00% <100.00%> (ø)` | | | [src/hazmat/miller\_rabin.rs](https://codecov.io/gh/entropyxyz/crypto-primes/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL2hhem1hdC9taWxsZXJfcmFiaW4ucnM=) | `99.44% <100.00%> (+0.02%)` | :arrow_up: | | [src/hazmat/sieve.rs](https://codecov.io/gh/entropyxyz/crypto-primes/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL2hhem1hdC9zaWV2ZS5ycw==) | `100.00% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Public changes:
nandn/2) when searching for safe primes (a dramatic performance increase)is_prime()etc - BPSW is enough, and sieving only slows the test down.sieve_once()is removed.Other changes:
decompose()since we now havetrailing_zeros()available