entropyxyz / crypto-primes

Random prime generation and primality testing library based on `crypto-bigint`.
https://docs.rs/crypto-primes
Apache License 2.0
17 stars 4 forks source link

Use verbs instead of nouns for prime-generation functions #24

Closed fjarri closed 1 year ago

fjarri commented 1 year ago

Rename prime() to generate_prime(), safe_prime() to generate_safe_prime(), prime_with_rng() to generate_prime_with_rng(), safe_prime_with_rng() to generate_safe_prime_with_rng(). Functions should have verb phrase names, and it also makes it easier to search for them

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (65ed5d4) 98.63% compared to head (61fcd64) 98.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #24 +/- ## ======================================= Coverage 98.63% 98.63% ======================================= Files 10 10 Lines 1316 1320 +4 ======================================= + Hits 1298 1302 +4 Misses 18 18 ``` | [Impacted Files](https://app.codecov.io/gh/entropyxyz/crypto-primes/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz) | Coverage Δ | | |---|---|---| | [src/lib.rs](https://app.codecov.io/gh/entropyxyz/crypto-primes/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL2xpYi5ycw==) | `100.00% <ø> (ø)` | | | [src/presets.rs](https://app.codecov.io/gh/entropyxyz/crypto-primes/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL3ByZXNldHMucnM=) | `99.02% <100.00%> (ø)` | | | [src/traits.rs](https://app.codecov.io/gh/entropyxyz/crypto-primes/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=entropyxyz#diff-c3JjL3RyYWl0cy5ycw==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.