search

entropyxyz / entropy-core

Protocol and cryptography development.
https://docs.entropy.xyz/
GNU Affero General Public License v3.0
11 stars 2 forks source link

Fix master build #1079

Closed JesseAbram closed 1 month ago

JesseAbram commented 1 month ago

Fixes master build by not querying potentially missed event then repinging until the event block had been pruned, this instead just goes to non pruning state of the chain

JesseAbram commented 1 month ago

🥇 Great that this works and CI is passing again.

I don't totally understand why it works. I am guessing it must be that sometimes the jumpstart finished event was happening whilst we were waiting for the http responses, and so we were missing it.

run_to_block(&rpc, block_number + 9).await; This feels like something which could break again easily when something changes either with the protocol or the hardware we run the tests on.

this should be fine this was because we.....I upped the refresh sent block from 5 to 7, so this created a race condition, now it should be good.

I feel like we keep getting problems in tests relating to mocking the OCW requests (eg the test_store_share test). I know you disagree but i think the way to go is to only mock these when you are specifically testing the behavior of that http endpoint.

mmmm fair we can bring it up on our next core meeting,