entropyxyz / entropy-core

Protocol and cryptography development.
https://docs.entropy.xyz/
GNU Affero General Public License v3.0
11 stars 2 forks source link

Add JSON output to select entropy-test-cli commands #1163

Closed cooldracula closed 1 week ago

cooldracula commented 1 week ago

Why is this issue relevant?

The entropy-test-cli is really useful in DevOps' ansible scripts for starting up a network and running basic smoke tests so we can run through the same release checklist as core, but on staging infrastructure.

It would be easier to automate these steps if there was JSON output for the relevant commands. This would let us reliably check that a command succeeded and assert our smoke tests are passing.

What steps are required to resolve this?

JSON Output in entropy-test-cli for the following commands :

Does this change the spec? HTTP, extrinsic, or storage? Is it breaking? Clearly describe the new interface.

It does not.

ameba23 commented 1 week ago

This is underway.

Worth noting though that you can already programmatically determine whether a command was successful or not with the process exit status code. All commands will exit with 0 on success and 1 on failure. So for commands like jumpstart, update-programs, remove-program, etc, which do not give you any information in the happy case, this should already be enough to use in a script.

ameba23 commented 1 week ago

@cooldracula this will get closed when i merge the PR, but please re-open if something else is needed, specifically: