Decouple `protocol` and `session` levels - Githubissues

entropyxyz / manul

Round-based distributed protocols

https://docs.rs/manul

GNU Affero General Public License v3.0

1 stars 1 forks source link

Decouple `protocol` and `session` levels #25

Open fjarri opened 5 days ago

fjarri commented 5 days ago

Ideally we would want protocol to know nothing of session. But currently there are several back-references:

FirstRound::new() needs to know about SessionId (see also #9),
LocalError and RemoteError are used on both levels. Should we have each layer have their own?
EchoRoundError is declared at the session level, but used at the protocol level as one of the variants of ReceiveError

Edit: Fixed/invalidated:

Protocol trait uses Digest trait, which is defined at the session level — using RustCrypto traits directly now