Proposal: we only support ESM

entropyxyz / sdk

Official JavaScript SDK for Entropy blockchain.

GNU Affero General Public License v3.0

8 stars 0 forks source link

Open mixmix opened 5 months ago

mixmix commented 5 months ago

Proposal we only support esm (import only, no require)?

Argument:

CJS is probably gonna die (esm can use cjs easy, not the other way)
use of the sdk is already async (entropy.ready)
https://nodejs.org/api/packages.html#packages_dual_package_hazard
can waste a lot of time + money (maybe I just don't want to go down into the dungeon ok)
package size halved

mixmix commented 5 months ago

@frankiebee and I discussed this. Probably want to support both if we can.

I recommend ESM is the exampled code we give, and make that the "first class citizen" if there is ever any compromise.