search

entropyxyz / sdk

Official JavaScript SDK for Entropy blockchain.
GNU Affero General Public License v3.0
7 stars 0 forks source link

drop .npmignore #323

Closed mixmix closed 1 month ago

mixmix commented 2 months ago

we have package.json files defined and I've confirmed it's working well we don't need this extra file

ref: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#files

mixmix commented 2 months ago

cc @frankiebee

frankiebee commented 1 month ago

Use a .npmignore file to keep stuff out of your package. If there's no .npmignore file, but there is a .gitignore file, then npm will ignore the stuff matched by the .gitignore file. If you want to include something that is excluded by your .gitignore file, you can create an empty .npmignore file to override it. Like git, npm looks for .npmignore and .gitignore files in all subdirectories of your package, not only the root directory.

frankiebee commented 1 month ago

does this mean are build wont get published?

mixmix commented 1 month ago

I don't think so @frankiebee , I think our files section in package.json says "only publish these files please"