Mix found things - Githubissues

entropyxyz / sdk

Official JavaScript SDK for Entropy blockchain.

GNU Affero General Public License v3.0

8 stars 0 forks source link

Mix found things #331

Open mixmix opened 5 months ago

mixmix commented 5 months ago

ExtrinsicBaseClass

[ ] constructor typescript doesn't appear to be catching the lack of substrate/ signer being passed in
[ ] get calling things JSON when they are jsObjects

Entropy

[ ] can't currently import (without dist/ jank)
[ ] descriptions needed for methods/ getters

EntropyAccount (interface)

[ ] more detail
[ ] muddle of sting | Signer inputs
[ ] make it clear what's optionsal when (it's almost like the SDK has multiple modes... that could be split out to add more clarity and help TS do it's job better)

EntropyOpts

[ ] make endpoint non-optional?
[ ] polkadot takes endpoint: string | [string], should we too?

Misc.

[ ] clarify account on entropy + the key scheme and how they are used
[ ] dev.deploy
- [ ] GIVE ME THE HASH (even if it's already deployed)
- [ ] confusing name. Just call it "deploy"
[ ] charlie magic
- [ ] document it's a "free" account / delete it

Tests

[ ] fetching things then not testing the results

dev/README.md

[ ] versions note update

frankiebee commented 2 months ago

@mixmix lets progress this