entropyxyz / sdk

Official JavaScript SDK for Entropy blockchain.
GNU Affero General Public License v3.0
7 stars 0 forks source link

[NayNay] Registration verifying keys being stripped at Keyring #353

Closed rh0delta closed 1 month ago

rh0delta commented 1 month ago

Description

GitHub Issue or Linear Task

How Has This Been Tested?

mixmix commented 1 month ago

@frankiebee review this please

frankiebee commented 1 month ago

This fixes?

issue found when trying to view programs for testnet address, verifying keys list was always empty even tho config contained the keys

you seem to only have only touched the signing file i would imagine the fix would be in sec/programs/index.ts

rh0delta commented 1 month ago

This fixes?

issue found when trying to view programs for testnet address, verifying keys list was always empty even tho config contained the keys

you seem to only have only touched the signing file i would imagine the fix would be in sec/programs/index.ts

the issue wasnt with programs, it was due to the data passed to the keyring from the cli not being persisted to the instantiation of the keyring instance, and so even if the account has verifying keys, according to the Keyring instance generated there were no keys or anything. the fix is in src/keys/index.ts. signing was touched because the device keys account had an empty list of verifying keys, so we had to work some magic to use the registration keys

rh0delta commented 1 month ago

we need to look more into how we are doing the storage for keyrings on the cli