search

entropyxyz / sdk

Official JavaScript SDK for Entropy blockchain.
GNU Affero General Public License v3.0
8 stars 0 forks source link

Mixmix/export dev #389

Closed mixmix closed 5 months ago

mixmix commented 5 months ago

fixes https://github.com/entropyxyz/sdk/issues/388

mixmix commented 5 months ago

hey @rh0delta I thought this was ready for review. If your review is "it's not, I think it needs more, moving it to draft" then can you review it and request changes?

rh0delta commented 5 months ago

hey @rh0delta I thought this was ready for review.

If your review is "it's not, I think it needs more, moving it to draft" then can you review it and request changes?

My apologies @mixmix should've added a comment for context. I've switched this PR to draft as I have some changes to add on my end in order to get the types and tests working on the CLI. I'll push them up once I get the tests working

rh0delta commented 5 months ago

@mixmix my updates are ready for review, very minor addition to the package json field explicitly defining the types destination for the keys export. I will review the rest of the PR, but would like your sign-off on those changes