Frankie/i#376 tsc - Githubissues

entropyxyz / sdk

Official JavaScript SDK for Entropy blockchain.

GNU Affero General Public License v3.0

8 stars 0 forks source link

Frankie/i#376 tsc #400

Closed mixmix closed 4 months ago

mixmix commented 4 months ago

Changes TS build:

use tsc (no build step)
change every relative import to specify file extension
- this is a hard requirement of type: module ESM setup :cry:
- side-stepping would require a more sugary build-tool
trim the tsconfig.json down, leave important notes

The tests all pass, BUT I've not been able to yarn link it in to @entropyxyz/cli because dev is broken at the moment.... oh I should try it in main...

mixmix commented 4 months ago

NOTE a lot of the ugliness of import { thing } from './utils/index.js' is because we have been leaning on the default CJS pattern of "yeah gimme a folder and I'll try the index.js file I guess".

If we re-work file/folder structure we can make it nicer like import { thing } from './utils.js'

frankiebee commented 4 months ago

closing in favor of #402