search

entropyxyz / synedrion

Implementation of Canetti-Gennaro-Goldfeder-Makriyannis-Peled threshold signing scheme
https://docs.rs/synedrion
GNU Affero General Public License v3.0
63 stars 10 forks source link

Use `SecretBox` for all secret values #144

Closed dvdplm closed 1 month ago

dvdplm commented 2 months ago

Wrap more secrets in SecretBox.

Keeping this PR as a draft, given it depends on a pre-release candidate for secrecy (see this issue).

When crypto-bigint v0.6 is released we can address one more TODO (this one).

Fixes #77

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.88%. Comparing base (9f9a0c4) to head (66b313f). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
synedrion/src/cggmp21/protocols/signing.rs 0.00% 3 Missing :warning:
synedrion/src/cggmp21/protocols/presigning.rs 93.54% 2 Missing :warning:
synedrion/src/paillier/params.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #144 +/- ## ========================================== + Coverage 90.72% 90.88% +0.15% ========================================== Files 44 45 +1 Lines 8066 8162 +96 ========================================== + Hits 7318 7418 +100 + Misses 748 744 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fjarri commented 1 month ago

I think this one should go in next, could you rebase it to master?