ZK proof cleanup

[fjarri]

• Include challenges in all ZK proofs. While not strictly necessary, according to the authors of the paper, still adds a little more security and more debug info at the price of slightly larger message sizes. Also we were already doing it for some of the ZK proofs anyway.
• Adjust method visibility (don't use pub(crate) for the methods of a struct that's already pub(crate))
• Bring some parameter names in sync with the paper
• Decouple curve scalars from big integers (fixes #63). Note that it adds some internal-use methods to SchemeParams; these should be hidden as a part of #74.
• TODO: add public values and commitments (if the ZK proof uses them) into the hash digest for challenge generation, as prescribed by Fig. 2

[vercel[bot]]

@fjarri is attempting to deploy a commit to the entropyxyz Team on Vercel.

A member of the Team first needs to authorize it.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
synedrion	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 19, 2024 0:15am

[codecov[bot]]

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (1e8f908) 87.17% compared to head (a851fff) 86.91%.

Files	Patch %	Lines
synedrion/src/cggmp21/protocols/signing.rs	0.00%	61 Missing :warning:
synedrion/src/cggmp21/protocols/presigning.rs	67.07%	27 Missing :warning:
synedrion/src/uint/signed.rs	96.00%	2 Missing :warning:
synedrion/src/cggmp21/params.rs	97.87%	1 Missing :warning:
synedrion/src/cggmp21/sigma/aff_g.rs	98.03%	1 Missing :warning:
synedrion/src/cggmp21/sigma/dec.rs	97.05%	1 Missing :warning:
synedrion/src/cggmp21/sigma/enc.rs	97.36%	1 Missing :warning:
synedrion/src/cggmp21/sigma/fac.rs	95.23%	1 Missing :warning:
synedrion/src/cggmp21/sigma/log_star.rs	97.56%	1 Missing :warning:
synedrion/src/cggmp21/sigma/mul.rs	96.87%	1 Missing :warning:
... and 2 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #99 +/- ## ========================================== - Coverage 87.17% 86.91% -0.26% ========================================== Files 45 45 Lines 7251 7535 +284 ========================================== + Hits 6321 6549 +228 - Misses 930 986 +56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.