search

entrusc / Pi-OLED

A Java driver for the popular monochrome SSD1306 128x64 OLED display (over i2c)
Other
22 stars 13 forks source link

Use Level.INFO insted of Level.FINE and fix an typo (i guess?) #7

Closed ElectroBoy404NotFound closed 2 years ago

entrusc commented 2 years ago

@ElectroBoy404NotFound can you please elaborate why you think this is an improvement to change the log level here to INFO when opening/closing the i2c bus?

ElectroBoy404NotFound commented 2 years ago

@ElectroBoy404NotFound can you please elaborate why you think this is an improvement to change the log level here to INFO when opening/closing the i2c bus?

I just think that it makes more sense. If you want, you can only merge the README changes.

ElectroBoy404NotFound commented 2 years ago

I mean, its just an line to tell the user that we are opening/closing the i2c bus, so it made more sense for me.

ElectroBoy404NotFound commented 2 years ago

Also, nice project you have over here!

entrusc commented 2 years ago

I mean, its just an line to tell the user that we are opening/closing the i2c bus, so it made more sense for me.

True, but some people prefer their log uncluttered with debug messages. But if you wanna see that message you can simply change the log level for the corresponding logger in your app to DEBUG.

ElectroBoy404NotFound commented 2 years ago

I mean, its just an line to tell the user that we are opening/closing the i2c bus, so it made more sense for me.

True, but some people prefer their log uncluttered with debug messages. But if you wanna see that message you can simply change the log level for the corresponding logger in your app to DEBUG.

Ahhh yes, i completly forgot about DEBUG.. Let me change that

ElectroBoy404NotFound commented 2 years ago

Also i'm updating it becuase i want my own copy even if you don't merge this pull.

ElectroBoy404NotFound commented 2 years ago

Should i close this pull?

entrusc commented 2 years ago

I incorporated your changes of the README.md to now not mention any specific IDE, but instead simply highlight how to build it using maven. I think every decent developer should be able to figure out how to open the project in their favorite IDE.

Thanks for your contribution :)

Closing this pull request now.

ElectroBoy404NotFound commented 2 years ago

@entrusc entrusc

ElectroBoy404NotFound commented 2 years ago

I incorporated your changes of the README.md to now not mention any specific IDE, but instead simply highlight how to build it using maven. I think every decent developer should be able to figure out how to open the project in their favorite IDE.

Thanks for your contribution :)

Closing this pull request now.

Oh, thanks!